Default cabal init application-dir to app, and source-dir to src. #6676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phadej
reviewed
Apr 9, 2020
m-renaud
force-pushed
the
m-renaud-init-app-dir-default
branch
from
f3e48e8 to
f470eac
Compare
|
Updated changelog.d/cabal-init as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the default directory for the main module as
app/(--application-dir=app) and library source files assrc/(--source-dir=src).This avoids the problem described in #6150 of having a library and executable share the same
hs-source-dirs. Even for just the executable case its best to have a separate directory because its likely that eventually code will be moved into internal libraries for testing (which should also have a separatehs-source-dirs).Tested manually, both interactively and non-interactively.
This resolves #6150.
Please include the following checklist in your PR:
[ci skip]is used to avoid triggering the build bots.Please also shortly describe how you tested your change. Bonus points for added tests!