Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .readthedocs.yml config file and pin to Python v2.7. #6668

Merged
merged 1 commit into from
Apr 7, 2020

Conversation

m-renaud
Copy link
Collaborator

@m-renaud m-renaud commented Apr 6, 2020

At some point ReadTheDocs switched the default Python version from 2.7 to 3.7 causing all Cabal user guide docs to no longer build. The error surfaces as:

  File "/home/docs/checkouts/readthedocs.org/user_builds/m-renaud-haskell-cabal/checkouts/mrenaud-docs-getting-started/Cabal/doc/cabaldomain.py", line 153
    sig = re.sub(ur'<([-a-zA-Z ]+)>', ur'⟨\1⟩', sig)

This PR adds a config file which pins to python 2.7, we really should just update cabaldomain.py to be compatible with Python 3.7, but that's for another day.

Verified this branch builds at: https://readthedocs.org/projects/m-renaud-haskell-cabal/builds/10780554/ (not sure if this is publicly visible or not).

Edit: after looking at https://readthedocs.org/projects/cabal/builds/, it appears the docs have built successfully, maybe there's some config in the admin panel :/ In any case, this is the more programmatic way to pin the version.

@m-renaud m-renaud merged commit d4ebb69 into haskell:master Apr 7, 2020
@m-renaud m-renaud deleted the m-renaud-cabal-docs-pin-pyv2 branch April 7, 2020 02:16
@phadej phadej mentioned this pull request Jul 10, 2020
@phadej phadej added this to the 3.4.0.0-rc1 milestone Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants