Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6610 Add pijul to known repository type #6665

Closed

Conversation

v0d1ch
Copy link
Contributor

@v0d1ch v0d1ch commented Apr 6, 2020

Unfortunately I could not install pijul on my machine and test out this pr so any help would be appreciated.

Copy link
Collaborator

@phadej phadej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll give it try locally in incoming days

EDIT: days, not months

@@ -693,3 +718,45 @@ vcsTestDriverDarcs mtimeChange verbosity vcs repoRoot =
}
darcs = runProgramInvocation verbosity . darcsInvocation


vcsTestDriverPijul :: Verbosity -> VCS ConfiguredProgram
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Having test is great. I'll take a look at CI so it won't fail

(Looks like there is no apt-get install pijul easy way of installing pijul on ubuntu)

vcsSyncRepos
}
where
vcsCloneRepo :: Verbosity -- ^ it seams that pijul does not have verbose flag
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm quite sure it does, let us find out.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... but indeed, it looks like there are no flags to affect output of pijul atm. Surprising :)

@v0d1ch v0d1ch force-pushed the 6610-add-pijul-to-known-repository-type branch 4 times, most recently from 4817756 to 479469b Compare April 7, 2020 14:50
@phadej
Copy link
Collaborator

phadej commented Apr 7, 2020

I got pijul installed, and it seems to work. I can continue from here!

Thanks for doing this @v0d1ch .

@v0d1ch v0d1ch force-pushed the 6610-add-pijul-to-known-repository-type branch from 479469b to f868d16 Compare April 7, 2020 15:18
@phadej phadej self-assigned this Apr 9, 2020
@phadej
Copy link
Collaborator

phadej commented Apr 10, 2020

Merged in #6684

@phadej phadej closed this Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants