setupAndCabalTest uses cabal act-as-setup for cabal part #6643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phadej
changed the title
|
I opened this PR with improper name first. It should been "setupAndCabalTest uses cabal act-as-setup for cabal part" . |
The cabal command interface will drift more and more from ./Setup interface. This is first step: don't assume they are the same. This removes need to "patch" setup commands to work with cabal: the `act-as-setup` SHOULD behave as (simple) ./Setup There were few setupAndCabalTests which weren't `build-type: Simple`. For those I made a separate `cabal.test.hs`. Also added a OutputNormalizer for global tmp directory. `v2-build` sdists `build-type: Custom` packages to get the list of files to watch. I guess it's ok to have that functionality, yet it could be eventually removed, as `v2-sdist` does not invoke `./Setup.hs` script.
phadej
force-pushed
the
cabal-testsuite-src-dir
branch
from
7196b28 to
ab35536
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.