Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the monolithic Init.hs module into 5 sub-modules. #6641

Closed
wants to merge 1 commit into from

Conversation

m-renaud
Copy link
Collaborator

@m-renaud m-renaud commented Apr 2, 2020

Init.Command - Main cabal init logic that ties everything together.
Init.Defaults - Default values for items not specified in config or arguments
Init.FileCreators - All the createXyz functions which write files (LICENSE, Main.hs, etc.)
Init.Prompt - Utilities for prompting the user for selections
Init.Utils - Misc utilities shared across the above modules


Please include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • If the change is docs-only, [ci skip] is used to avoid triggering the build bots.

Please also shortly describe how you tested your change. Bonus points for added tests!

@m-renaud
Copy link
Collaborator Author

m-renaud commented Apr 2, 2020

FYI @phadej previous PR was automatically closed when I reset the branch to fix the merge conflict. Was easier just to create a new branch and PR.

@phadej phadej self-assigned this Apr 2, 2020
@m-renaud
Copy link
Collaborator Author

m-renaud commented Apr 2, 2020

Huh, interesting CI failures:

fatal: reference is not a tree: df13421f2d5c60a4846e7de763a7bfa1adbcae06

😕

@m-renaud
Copy link
Collaborator Author

m-renaud commented Apr 2, 2020

Looks like it may be caused by a race condition in GitHub actions: actions/checkout#23

@phadej
Copy link
Collaborator

phadej commented Apr 2, 2020

@m-renaud try to force push, that should fix that. Thanks for upstream reference.

Init.Command - Main cabal init logic that ties everything together.
Init.Defaults - Default values for items not specified in config or arguments
Init.FileCreators - All the createXyz functions which write files (LICENSE, Main.hs, etc.)
Init.Prompt - Utilities for prompting the user for selections
Init.Utils - Misc utilities shared across the above modules
@m-renaud
Copy link
Collaborator Author

m-renaud commented Apr 3, 2020

Sigh, looks like a lot of the checks are hanging now..

@phadej
Copy link
Collaborator

phadej commented Apr 4, 2020

I restarted linux jobs, will merge if they are green.

@m-renaud
Copy link
Collaborator Author

m-renaud commented Apr 4, 2020

Closing this PR since it was merged in #6650.

@m-renaud m-renaud closed this Apr 4, 2020
@phadej phadej mentioned this pull request Jul 10, 2020
@phadej phadej added this to the 3.4.0.0-rc1 milestone Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants