6432 - Split RepoType into type with known VCS and other

[v0d1ch]

fixes #6432

Previously we had:

data RepoType = Darcs | Git | SVN | CVS
              | Mercurial | GnuArch | Bazaar | Monotone
              | OtherRepoType String

And these changes split the RepoType into two like this:

data KnownRepoType = Darcs | Git | SVN | CVS
                   | Mercurial | GnuArch | Bazaar | Monotone

data RepoType = KnownRepoType KnownRepoType
              | OtherRepoType String

[phadej]

You should

# enable building dev build cabal-install
make cabal-install-dev

# hack and
cabal build all

# Revert cabal-install-dev changes
make cabal-install-prod
git commit --amend

[phadej]

Looks good. Made few comments.

[v0d1ch]

@phadej Thanks for the review! I made needed changes. Btw is there a way for me to assign myself to the issues I want to work on?

[v0d1ch]

@phadej I see The operation was canceled in failing tests and it seems that test suite was finished with success?

 Validate lib-tests5h 45m 1s
##[error]The operation was canceled.
Run sh validate.sh -j 2 -w ghc-8.8.3 -v --solver-benchmarks -s lib-tests
=== Cabal: tests =============================================== 22:24:54 ===
>>> /__w/cabal/cabal/dist-newstyle-validate-ghc-8.8.3/build/x86_64-linux/ghc-8.8.3/Cabal-3.3.0.0/t/unit-tests/build/unit-tests/unit-tests -j2 --hide-successes --with-ghc=ghc-8.8.3 
File modification time resolution calibration completed, maximum delay
observed: 16.528 ms. Will be using delay of 33.056 for test runs.
("[1 of 1] Compiling Main             ( /tmp/20405-2.hs, /tmp/20405-2.o )\nLinking /tmp/20405-3.exe ...\n","",ExitSuccess)

[phadej]

Thanks!