Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't write Setup.hs file during cabal init. #6603

Merged
merged 1 commit into from
Mar 25, 2020

Conversation

m-renaud
Copy link
Collaborator

When build-type: Simple the contents of Setup.hs MUST BE standard. It is only
in advanced cases where a custom setup file is needed.

This also has the positive consequence of simplifying the directory contents created during package initialization.


Please include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • If the change is docs-only, [ci skip] is used to avoid triggering the build bots.

Please also shortly describe how you tested your change. Bonus points for added tests!

When `build-type: Simple` the contents of Setup.hs MUST BE standard. It is only
in advanced cases where a custom setup file is needed.
@m-renaud m-renaud requested a review from phadej March 22, 2020 02:05
@DanielG
Copy link
Collaborator

DanielG commented Mar 25, 2020

Could you explain what exactly you're trying to accomplish here?

While Setup.hs isn't technically required to build a package with cabal some distributions such as Debian still use it to build haskell packages directly from tarballs, without exe:cabal involved.

@phadej
Copy link
Collaborator

phadej commented Mar 25, 2020

@DanielG they could (and should) use standard Setup.hs. There are packages on Hackage which don't have Setup.hs inside them.

@DanielG
Copy link
Collaborator

DanielG commented Mar 25, 2020

Huh, I'd assumed we're enforcing Setup.hs existing in hackage-serever. Well nevermind then.

@m-renaud
Copy link
Collaborator Author

Any other concerns or should I go ahead and merge this in? CI is all green.

@phadej
Copy link
Collaborator

phadej commented Mar 25, 2020

@m-renaud go ahead.

@m-renaud m-renaud merged commit 40cd3f1 into haskell:master Mar 25, 2020
@m-renaud m-renaud deleted the mrenaud-init-no-setup branch March 25, 2020 22:29
@phadej phadej mentioned this pull request Jul 10, 2020
@phadej phadej added this to the 3.4.0.0-rc1 milestone Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants