Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Described to IndexState (incl. tests). #6591

Merged
merged 1 commit into from
Mar 16, 2020
Merged

Add Described to IndexState (incl. tests). #6591

merged 1 commit into from
Mar 16, 2020

Conversation

phadej
Copy link
Collaborator

@phadej phadej commented Mar 16, 2020

  • Writing a regex to parse dates is awful.
  • Add ShortText conversions to PackageName and UnqualComponentName
  • Add mkDependency, which maintains the invariant
  • Remove VersionRangeParens - it's not preserved by parsec . pretty roundtrip
  • Move moree instances into Cabal-quickcheck,use the package in cabal-install tests

@phadej
Add Described to IndexState (incl. tests).
e45b013 
- Writing a regex to parse dates is awful.
- Add ShortText conversions to PackageName and UnqualComponentName
- Add mkDependency, which maintains the invariant
- Remove VersionRangeParens - it's not preserved by parsec . pretty
  roundtrip
- Move moree instances into Cabal-quickcheck,
  use the package in cabal-install tests
@phadej phadej merged commit b71d3db into haskell:master Mar 16, 2020
@phadej phadej deleted the index-state-tests branch March 16, 2020 21:55
@phadej phadej mentioned this pull request Jul 10, 2020
Merged
@phadej phadej added this to the 3.4.0.0-rc1 milestone Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4.0.0-rc1
Development

Successfully merging this pull request may close these issues.
1 participant
@phadej