More checks in version range parser #6586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phadej
force-pushed
the
more-checks-in-version-range-parser
branch
2 times, most recently
from
e67f193 to
ef0699a
Compare
- remove parallel code, it's complicated and doesn't speedup reliably - count files with warning - add --keep-going - add `clock` measurement from inside the parsec test
Do this already in the Parsec instance parser.
This allows removing checks from `D.PD.Check`.
Later this would also allow removing non-relevant
constructors from `VersionRange`, allowing easier testing.
This change causes 10% slowdown: from
```
135768 files processed
7350 files contained warnings
113156 files have check warnings
0 files failed to parse
120.901201s elapsed
117.640431s elapsed
119.663620s elapsed
119.454329s elapsed
119.785214s elapsed
```
to
```
135768 files processed
31912 files contained warnings
113109 files have check warnings
0 files failed to parse
130.969593s elapsed
132.016403s elapsed
134.214536s elapsed
128.753382s elapsed
131.503804s elapsed
```
I hope the slowdown is acceptable, and I have an idea which may mitigate
this. I'll try out it after I done further refactorings.
Note how (parser) warnings grew by a factor. There are plenty of (old)
files on Hackage, which don't use correct cabal-version. For that
reason we only issue warnings, and not fail. Quirks approach won't
scale for these. In comparison, there are even more files
with check warnings
phadej
force-pushed
the
more-checks-in-version-range-parser
branch
from
ef0699a to
2afbd0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.