Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Reference default-extensions from ghc-options #6560

Merged
merged 1 commit into from
Feb 25, 2020
Merged

docs: Reference default-extensions from ghc-options #6560

merged 1 commit into from
Feb 25, 2020

Conversation

Jassob
Copy link
Contributor

@Jassob Jassob commented Feb 25, 2020

Previously the user's guide stated that the extensions field was
preferred over ghc-options even though extensions are deprecated
in favour for default-extensions.

[ci skip]

Please include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • If the change is docs-only, [ci skip] is used to avoid triggering the build bots.

Please also shortly describe how you tested your change. Bonus points for added tests!

@Jassob
Copy link
Contributor Author

Jassob commented Feb 25, 2020

Hmm, it seems that I did not manage to skip the CI.. I apologize :(

Previously the user's guide stated that the extensions field was
preferred over ghc-options, even though extensions are deprecated in
favour for default-extensions. This commit updates the reference to
default-extensions instead.
@phadej
Copy link
Collaborator

phadej commented Feb 25, 2020

Thanks.

I have to update skipping CI thing, I guess GitHub actions can be made to not run if there're some predefined keywords, yet I'm not sure that we want that, as they are relatively fast to run.

@phadej phadej merged commit 89396ec into haskell:master Feb 25, 2020
@Jassob Jassob deleted the fix-outdated-reference branch February 25, 2020 19:27
@phadej phadej added this to the 3.4.0.0-rc1 milestone Jul 10, 2020
@phadej phadej mentioned this pull request Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants