Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct a typo in README [ci skip] #6550

Merged
merged 1 commit into from
Feb 21, 2020
Merged

Correct a typo in README [ci skip] #6550

merged 1 commit into from
Feb 21, 2020

Conversation

felixonmars
Copy link
Collaborator

@felixonmars felixonmars commented Feb 20, 2020 •
edited
Loading

Please include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • If the change is docs-only, [ci skip] is used to avoid triggering the build bots.

Please also shortly describe how you tested your change. Bonus points for added tests!

@phadej
Copy link
Collaborator

phadej commented Feb 21, 2020

Thanks.

For the future I think we shouldn't push branches to the upstream, at least named as generically as fix-typo.

@phadej phadej merged commit 6c64494 into master Feb 21, 2020
@phadej phadej deleted the fix-typo branch February 21, 2020 13:53
@felixonmars
Copy link
Collaborator Author

I see. Sorry for that!

@phadej phadej added this to the 3.4.0.0-rc1 milestone Jul 10, 2020
@phadej phadej mentioned this pull request Jul 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4.0.0-rc1
Development

Successfully merging this pull request may close these issues.
2 participants
@felixonmars @phadej