Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub Actions #6469

Merged
merged 2 commits into from
Dec 31, 2019
Merged

Use GitHub Actions #6469

merged 2 commits into from
Dec 31, 2019

Conversation

phadej
Copy link
Collaborator

@phadej phadej commented Dec 28, 2019

I'm not removing .travis.yml just yet. Let's have it on until 3.2 is done.

I'll cleanup the generation (there's todo about documenting it), will do that early 2020 and then merge. Please comment before that. The setup is simpler, but I'm not 100% if it has same the coverage as current travis setup

  • pro simpler
  • pro uses validate.sh, so you have better chance to reproduce on own machine
  • con even closer integration with GitHub
    • yet, the new setup is less GitHub specific than the current setup is Travis specific, so I guess it's not that bad

@phadej phadej requested review from 23Skidoo and hvr December 28, 2019 19:06
@phadej phadej changed the title WIP: Use GitHub Actions Use GitHub Actions Dec 29, 2019
@phadej phadej merged commit 668eaac into master Dec 31, 2019
@hvr
Copy link
Member

hvr commented Dec 31, 2019

@phadej did you intentionally not include any generated gh-workflow script in the PR (so that we could see the script in action)? nevermind; GH's UI is just weird...

@phadej phadej deleted the workflow-validate branch December 31, 2019 14:58
@phadej phadej added this to the 3.2.0.0 milestone Jul 10, 2020
@phadej phadej mentioned this pull request Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants