Grayjay update solver benchmarks #6447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes haskell#6417. Changes in this commit: - Set the --lib flag so that the benchmark works for packages with libraries or executables. - Set --ignore-project to prevent cabal projects from affecting the results. - Handle four types of cabal errors that were introduced by v2-install. - Use +nowrap to simplify parsing of cabal errors.
4 tasks
|
Thanks! |
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One commit on top of #6434 which allows to run benchmarks as part of
validate.sh(to see that they work).Probably because of asserts in development version,
cabal-install-3.0.1.0seems to be slightly faster, on my machine :)cc @grayjay, I'll merge this when travis turns green.