Make Setup.hs copy/install work when data-files uses **.
#6127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Treating globs like filenames was always illegitimate, but this code was broken further by the addition of recursive globs. I had a look around for other dubious code along these lines, and it looks like this site is the only problematic one. Fixes haskell#6125.
|
@23Skidoo: this isn't too late for 3.0, right? It's a pretty bad bug, since it's possible for the package author to never run these code paths before publishing and breaking users. |
|
Hopefully we can squeeze this in |
|
OK - the failure is a time-out on one of the OSX builders, which are known to be flaky. Since this comes with a test and the fix is easy to eyeball-verify, I'll go ahead and merge to master. I'll leave the 3.0 merging up to you? |
Closed
|
Cherry-picked to 3.0. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treating globs like filenames was always illegitimate, but this code
was broken further by the addition of recursive globs.
I had a look around for other dubious code along these lines, and it
looks like this site is the only problematic one.
Fixes #6125.
Please include the following checklist in your PR:
[ci skip]is used to avoid triggering the build bots.Please also shortly describe how you tested your change. Bonus points for added tests!