Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix « cabal »'s bash-completion (see issue #5927) #5928

Merged
merged 1 commit into from
Mar 10, 2019

Conversation

sboosali
Copy link
Collaborator

@sboosali sboosali commented Mar 8, 2019

  • ran shellcheck (a bash linter) on ./
  • add shopt -s nullglob to _cabal_list_targets

tested manually (tabbing in a bash shell) and via shellcheck.


Please include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • If the change is docs-only, [ci skip] is used to avoid triggering the build bots.

Please also shortly describe how you tested your change. Bonus points for added tests!

* ran `shellcheck` (a bash linter) on `./`
* add `shopt -s nullglob` to `_cabal_list_targets`
@23Skidoo 23Skidoo requested a review from kolmodin March 8, 2019 06:15
@23Skidoo
Copy link
Member

23Skidoo commented Mar 8, 2019

/cc @kolmodin

@23Skidoo
Copy link
Member

@sboosali I don't use Bash completion, but the patch looks reasonable and I'm willing to trust you that this PR improves the current state of affairs.

@kolmodin Feel free to revert if you disagree.

@23Skidoo 23Skidoo merged commit 7eac6a7 into haskell:master Mar 10, 2019
@23Skidoo
Copy link
Member

Merged, thanks!

@sboosali
Copy link
Collaborator Author

sboosali commented Mar 10, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants