Increase max-backjumps default from 2000 to 4000
#5886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last time the max-backjumps was increased was back in 2014 (see 0229cd5) as suggested per haskell#1780, and while `--reorder-goals` might often help as well, it also often comes at a bigger runtime penalty on average than doubling the max-backjumps. This should also address issues such as haskell#5882
grayjay
approved these changes
Feb 12, 2019
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last time the max-backjumps was increased was back in 2014
(see 0229cd5) as suggested
per #1780, and while
--reorder-goalsmight often help as well,it also often comes at a bigger runtime penalty on average than
doubling the max-backjumps.
This should also address issues such as #5882
Please include the following checklist in your PR:
[ci skip]is used to avoid triggering the build bots.Please also shortly describe how you tested your change. Bonus points for added tests!