Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info on common stanzas to Quickstart module import section #5861

Merged
merged 1 commit into from
Jan 24, 2019

Conversation

m-renaud
Copy link
Collaborator

@m-renaud m-renaud commented Jan 24, 2019

Add a paragraph about common stanzas to the "Modules imported from other packages" section in Quickstart. This improves discoverability of this cabal feature which is currently somewhat difficult to find.

Fixes #5860.

Rendered docs: https://i.imgur.com/OcOgFhy.png

/cc @david-christiansen


Please include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • If the change is docs-only, [ci skip] is used to avoid triggering the build bots.

@23Skidoo 23Skidoo merged commit e388548 into haskell:master Jan 24, 2019
@23Skidoo
Copy link
Member

Merged, thanks!

@m-renaud m-renaud deleted the mrenaud-docs-common-in-quickstart branch January 24, 2019 23:11
@david-christiansen
Copy link
Contributor

Thank you so much!

@m-renaud
Copy link
Collaborator Author

@23Skidoo what's the process for releasing/backporting doc changes to the current branch? I assume all these changes will go out when cabal 3.0 is released, but this one in particular would be useful to have in previous versions of the docs.

23Skidoo added a commit that referenced this pull request Jan 25, 2019
Add info on common stanzas to Quickstart module import section

(cherry picked from commit e388548)
@23Skidoo
Copy link
Member

Cherry-picked to the 2.4 branch.

@cartazio
Copy link
Contributor

cartazio commented Mar 2, 2019

@23Skidoo the docs fail to mention import needs to be first field of stanza requirement

@phadej
Copy link
Collaborator

phadej commented Mar 2, 2019

@cartazio
Copy link
Contributor

cartazio commented Mar 3, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants