Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Incorrect tar.gz Extension #5758

Merged
merged 4 commits into from
Dec 2, 2018
Merged

Fix Incorrect tar.gz Extension #5758

merged 4 commits into from
Dec 2, 2018

Conversation

emilypi
Copy link
Member

@emilypi emilypi commented Dec 2, 2018

@emilypi emilypi requested review from 23Skidoo and phadej December 2, 2018 22:00
23Skidoo
23Skidoo approved these changes Dec 2, 2018
View reviewed changes
Copy link
Member

@23Skidoo 23Skidoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emilypi emilypi changed the title fix for improper .tar.gz designation Fix Incorrect tar.gz Extension Dec 2, 2018
@emilypi emilypi requested a review from hvr December 2, 2018 22:15
@emilypi
Copy link
Member Author

emilypi commented Dec 2, 2018 •
edited
Loading

Got the go-ahead from @hvr to merge and tests pass 👍

@emilypi emilypi merged commit a29abd1 into haskell:master Dec 2, 2018
@phadej
Copy link
Collaborator

phadej commented Dec 3, 2018

Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@23Skidoo 23Skidoo 23Skidoo approved these changes

@phadej phadej Awaiting requested review from phadej

@hvr hvr Awaiting requested review from hvr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emilypi @phadej @23Skidoo