Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new-clean should not delete dist-newstyle/src #5701

Merged
merged 2 commits into from
Nov 21, 2018
Merged

new-clean should not delete dist-newstyle/src #5701

merged 2 commits into from
Nov 21, 2018

Conversation

typedrat
Copy link
Collaborator

Fixes #5699.


Please include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • If the change is docs-only, [ci skip] is used to avoid triggering the build bots.

Please also shortly describe how you tested your change. Bonus points for added tests!

@typedrat typedrat merged commit 3dfc642 into master Nov 21, 2018
@23Skidoo
Copy link
Member

👍

@fommil
Copy link
Contributor

fommil commented Nov 21, 2018

@typedrat awesome stuff! Do you think we could get this into the next release (scheduled very soon, I hear)

23Skidoo pushed a commit that referenced this pull request Nov 21, 2018
new-clean should not delete dist-newstyle/src

(cherry picked from commit 3dfc642)
@23Skidoo
Copy link
Member

Cherry-picked into 2.4.

@23Skidoo 23Skidoo deleted the fix-5699 branch October 11, 2019 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants