Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable bootstrap script to download and use local unpacked dependencies #5670

Merged
merged 1 commit into from
Nov 7, 2018

Conversation

watashi
Copy link
Collaborator

@watashi watashi commented Nov 6, 2018

  • bootstrap.sh can use local tarball, this change enhances it by using
    the unpacked local directory if that exists, so it's possible to play
    with a patch of a dependency locally.
  • a flag --no-install is added, so we can fetch and unpack all
    dependencies without actually installing them. this will allow us to
    later patch or build standalone cabal offline.

Test plan:

./bootstrap.sh --no-install downloads a bunch of packages and
I can run ./bootstrap.sh later to build cabal without network.


Please include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • If the change is docs-only, [ci skip] is used to avoid triggering the build bots.

Please also shortly describe how you tested your change. Bonus points for added tests!

* bootstrap.sh can use local tarball, this change enhances it by using
  the unpacked local directory if that exists, so it's possible to play
  with a patch of a dependency locally.
* a flag `--no-install` is added, so we can fetch and unpack all
  dependencies without actually installing them. this will allow us to
  later patch or build standalone cabal offline.
@watashi
Copy link
Collaborator Author

watashi commented Nov 6, 2018

cc: @simonmar

haskell-pushbot pushed a commit to haskell-pushbot/cabal-binaries that referenced this pull request Nov 6, 2018
"url":"pull/5670",
"account":"haskell",
"repo":"cabal",
"commit": "5bc88cd3ea97e3888d81dd9d125db34001b8cd94",
"tag":"linux-7.10.3"
}
haskell-pushbot pushed a commit to haskell-pushbot/cabal-binaries that referenced this pull request Nov 6, 2018
"url":"pull/5670",
"account":"haskell",
"repo":"cabal",
"commit": "5bc88cd3ea97e3888d81dd9d125db34001b8cd94",
"tag":"linux-7.8.4"
}
haskell-pushbot pushed a commit to haskell-pushbot/cabal-binaries that referenced this pull request Nov 6, 2018
"url":"pull/5670",
"account":"haskell",
"repo":"cabal",
"commit": "5bc88cd3ea97e3888d81dd9d125db34001b8cd94",
"tag":"linux-8.0.2"
}
haskell-pushbot pushed a commit to haskell-pushbot/cabal-binaries that referenced this pull request Nov 6, 2018
"url":"pull/5670",
"account":"haskell",
"repo":"cabal",
"commit": "5bc88cd3ea97e3888d81dd9d125db34001b8cd94",
"tag":"linux-7.6.3"
}
haskell-pushbot pushed a commit to haskell-pushbot/cabal-binaries that referenced this pull request Nov 6, 2018
"url":"pull/5670",
"account":"haskell",
"repo":"cabal",
"commit": "5bc88cd3ea97e3888d81dd9d125db34001b8cd94",
"tag":"linux-8.2.2"
}
haskell-pushbot pushed a commit to haskell-pushbot/cabal-binaries that referenced this pull request Nov 6, 2018
"url":"pull/5670",
"account":"haskell",
"repo":"cabal",
"commit": "5bc88cd3ea97e3888d81dd9d125db34001b8cd94",
"tag":"linux-8.4.4"
}
haskell-pushbot pushed a commit to haskell-pushbot/cabal-binaries that referenced this pull request Nov 6, 2018
"url":"pull/5670",
"account":"haskell",
"repo":"cabal",
"commit": "5bc88cd3ea97e3888d81dd9d125db34001b8cd94",
"tag":"linux-8.4.4-fdebug-expensive-assertions"
}
haskell-pushbot pushed a commit to haskell-pushbot/cabal-binaries that referenced this pull request Nov 6, 2018
"url":"pull/5670",
"account":"haskell",
"repo":"cabal",
"commit": "5bc88cd3ea97e3888d81dd9d125db34001b8cd94",
"tag":"linux-8.6.2"
}
haskell-pushbot pushed a commit to haskell-pushbot/cabal-binaries that referenced this pull request Nov 6, 2018
"url":"pull/5670",
"account":"haskell",
"repo":"cabal",
"commit": "5bc88cd3ea97e3888d81dd9d125db34001b8cd94",
"tag":"osx-7.8.4"
}
haskell-pushbot pushed a commit to haskell-pushbot/cabal-binaries that referenced this pull request Nov 6, 2018
"url":"pull/5670",
"account":"haskell",
"repo":"cabal",
"commit": "5bc88cd3ea97e3888d81dd9d125db34001b8cd94",
"tag":"osx-8.0.2"
}
Copy link
Member

@23Skidoo 23Skidoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@23Skidoo 23Skidoo merged commit 0562824 into haskell:master Nov 7, 2018
@23Skidoo
Copy link
Member

23Skidoo commented Nov 7, 2018

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants