Tell the user about --lib when new-installing a package with no exes #5666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgaz
commented
Nov 6, 2018
| @@ -614,8 +614,16 @@ symlinkBuiltPackage :: Verbosity | |||
| symlinkBuiltPackage verbosity overwritePolicy | |||
| mkSourceBinDir destDir | |||
| (pkg, components) = | |||
| traverse_ symlinkAndWarn exes | |||
| if null exes | |||
| then warn verbosity $ "You asked to install executables, " | |||
There was a problem hiding this comment.
I'm for warn, since technically cabal succeeds in installing "all the exes of the package"
fgaz
force-pushed
the
new-install/no-exes-warn
branch
from
0151e81 to
f6aaeee
Compare
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Nov 6, 2018
"url":"pull/5666", "account":"haskell", "repo":"cabal", "commit": "f6aaeeeae3daca0240a6192024934f4b2143412e", "tag":"linux-7.6.3" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Nov 6, 2018
"url":"pull/5666", "account":"haskell", "repo":"cabal", "commit": "f6aaeeeae3daca0240a6192024934f4b2143412e", "tag":"linux-7.8.4" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Nov 6, 2018
"url":"pull/5666", "account":"haskell", "repo":"cabal", "commit": "f6aaeeeae3daca0240a6192024934f4b2143412e", "tag":"linux-8.2.2" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Nov 6, 2018
"url":"pull/5666", "account":"haskell", "repo":"cabal", "commit": "f6aaeeeae3daca0240a6192024934f4b2143412e", "tag":"linux-7.10.3" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Nov 6, 2018
"url":"pull/5666", "account":"haskell", "repo":"cabal", "commit": "f6aaeeeae3daca0240a6192024934f4b2143412e", "tag":"linux-8.0.2" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Nov 6, 2018
"url":"pull/5666", "account":"haskell", "repo":"cabal", "commit": "f6aaeeeae3daca0240a6192024934f4b2143412e", "tag":"linux-8.4.4" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Nov 6, 2018
"url":"pull/5666", "account":"haskell", "repo":"cabal", "commit": "f6aaeeeae3daca0240a6192024934f4b2143412e", "tag":"linux-8.6.2" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Nov 6, 2018
"url":"pull/5666", "account":"haskell", "repo":"cabal", "commit": "f6aaeeeae3daca0240a6192024934f4b2143412e", "tag":"linux-8.4.4-fdebug-expensive-assertions" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Nov 6, 2018
"url":"pull/5666", "account":"haskell", "repo":"cabal", "commit": "f6aaeeeae3daca0240a6192024934f4b2143412e", "tag":"osx-7.8.4" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Nov 6, 2018
"url":"pull/5666", "account":"haskell", "repo":"cabal", "commit": "f6aaeeeae3daca0240a6192024934f4b2143412e", "tag":"osx-7.10.3" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Nov 6, 2018
"url":"pull/5666", "account":"haskell", "repo":"cabal", "commit": "f6aaeeeae3daca0240a6192024934f4b2143412e", "tag":"osx-8.0.2" }
23Skidoo
approved these changes
Nov 7, 2018
| @@ -614,8 +614,16 @@ symlinkBuiltPackage :: Verbosity | |||
| symlinkBuiltPackage verbosity overwritePolicy | |||
| mkSourceBinDir destDir | |||
| (pkg, components) = | |||
| traverse_ symlinkAndWarn exes | |||
| if null exes | |||
| then warn verbosity $ "You asked to install executables, " | |||
|
Huh, 100% green, nice. Did CI fix itself? |
|
I think 5bc88cd fixed it |
fgaz
added a commit
that referenced
this pull request
Nov 8, 2018
Tell the user about --lib when new-installing a package with no exes
|
Cherry-picked to 2.4 |
|
@fgaz Oh BTW, when you cherry-pick patches, please use
Hmm, how? Bootstrap configuration was green before. I think it was the release of 8.6.2 final (that configuration was failing), but I'm not sure what exactly changed. |
oh,sorry. I'll do that from now on.
that's probably it then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @hvr