Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleans up the -Werror check, adds GHC 8.6.1 support and also filters RTS flags, fixing #5575 #5589

Merged
merged 2 commits into from
Nov 8, 2018
Merged

Cleans up the -Werror check, adds GHC 8.6.1 support and also filters RTS flags, fixing #5575 #5589

merged 2 commits into from
Nov 8, 2018

Conversation

merijn
Copy link
Collaborator

@merijn merijn commented Sep 25, 2018

This change should be backported to the 2.4 branch for the next point release.

Please include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • If the change is docs-only, [ci skip] is used to avoid triggering the build bots.

Please also shortly describe how you tested your change. Bonus points for added tests!

@hvr hvr added this to the 2.4.0.1 milestone Sep 25, 2018
haskell-pushbot pushed a commit to haskell-pushbot/cabal-binaries that referenced this pull request Sep 25, 2018
@merijn
{"origin":"haskell/cabal/pull/5589",
d4d40de 
"url":"pull/5589",
"account":"haskell",
"repo":"cabal",
"commit": "048b75897c07cc42d9a081d459aa4cc6717f7e94",
"tag":"linux-8.0.2"
}
haskell-pushbot pushed a commit to haskell-pushbot/cabal-binaries that referenced this pull request Sep 25, 2018
@merijn
{"origin":"haskell/cabal/pull/5589",
a667937 
"url":"pull/5589",
"account":"haskell",
"repo":"cabal",
"commit": "048b75897c07cc42d9a081d459aa4cc6717f7e94",
"tag":"linux-7.10.3"
}
haskell-pushbot pushed a commit to haskell-pushbot/cabal-binaries that referenced this pull request Sep 25, 2018
@merijn
{"origin":"haskell/cabal/pull/5589",
e91223a 
"url":"pull/5589",
"account":"haskell",
"repo":"cabal",
"commit": "048b75897c07cc42d9a081d459aa4cc6717f7e94",
"tag":"linux-7.6.3"
}
haskell-pushbot pushed a commit to haskell-pushbot/cabal-binaries that referenced this pull request Sep 25, 2018
@merijn
{"origin":"haskell/cabal/pull/5589",
da46826 
"url":"pull/5589",
"account":"haskell",
"repo":"cabal",
"commit": "048b75897c07cc42d9a081d459aa4cc6717f7e94",
"tag":"linux-8.4.3"
}
haskell-pushbot pushed a commit to haskell-pushbot/cabal-binaries that referenced this pull request Sep 25, 2018
@merijn
{"origin":"haskell/cabal/pull/5589",
ec53a55 
"url":"pull/5589",
"account":"haskell",
"repo":"cabal",
"commit": "048b75897c07cc42d9a081d459aa4cc6717f7e94",
"tag":"linux-8.2.2"
}
haskell-pushbot pushed a commit to haskell-pushbot/cabal-binaries that referenced this pull request Sep 25, 2018
@merijn
{"origin":"haskell/cabal/pull/5589",
219dd09 
"url":"pull/5589",
"account":"haskell",
"repo":"cabal",
"commit": "048b75897c07cc42d9a081d459aa4cc6717f7e94",
"tag":"linux-8.4.3-fdebug-expensive-assertions"
}
haskell-pushbot pushed a commit to haskell-pushbot/cabal-binaries that referenced this pull request Sep 25, 2018
@merijn
{"origin":"haskell/cabal/pull/5589",
b44ce37 
"url":"pull/5589",
"account":"haskell",
"repo":"cabal",
"commit": "048b75897c07cc42d9a081d459aa4cc6717f7e94",
"tag":"osx-7.8.4"
}
@23Skidoo 23Skidoo mentioned this pull request Sep 25, 2018
Closed
@merijn merijn mentioned this pull request Oct 24, 2018
Closed
haskell-pushbot pushed a commit to haskell-pushbot/cabal-binaries that referenced this pull request Oct 30, 2018
@merijn
{"origin":"haskell/cabal/pull/5589",
e077200 
"url":"pull/5589",
"account":"haskell",
"repo":"cabal",
"commit": "048b75897c07cc42d9a081d459aa4cc6717f7e94",
"tag":"linux-7.8.4"
}
haskell-pushbot pushed a commit to haskell-pushbot/cabal-binaries that referenced this pull request Nov 8, 2018
@merijn
{"origin":"haskell/cabal/pull/5589",
a22c14f 
"url":"pull/5589",
"account":"haskell",
"repo":"cabal",
"commit": "048b75897c07cc42d9a081d459aa4cc6717f7e94",
"tag":"osx-8.0.2"
}
haskell-pushbot pushed a commit to haskell-pushbot/cabal-binaries that referenced this pull request Nov 8, 2018
@merijn
{"origin":"haskell/cabal/pull/5589",
e137ae5 
"url":"pull/5589",
"account":"haskell",
"repo":"cabal",
"commit": "048b75897c07cc42d9a081d459aa4cc6717f7e94",
"tag":"osx-7.10.3"
}
haskell-pushbot pushed a commit to haskell-pushbot/cabal-binaries that referenced this pull request Nov 8, 2018
@merijn
{"origin":"haskell/cabal/pull/5589",
55ddeb7 
"url":"pull/5589",
"account":"haskell",
"repo":"cabal",
"commit": "048b75897c07cc42d9a081d459aa4cc6717f7e94",
"tag":"osx-7.10.3"
}
23Skidoo
23Skidoo approved these changes Nov 8, 2018
View reviewed changes
Copy link
Member

@23Skidoo 23Skidoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@23Skidoo 23Skidoo merged commit e263e8c into haskell:master Nov 8, 2018
@23Skidoo
Copy link
Member

23Skidoo commented Nov 8, 2018

Merged, thanks! Sorry for the delay.

23Skidoo added a commit that referenced this pull request Nov 8, 2018
@23Skidoo
Merge pull request #5589 from merijn/master
288acca 
Cleans up the `-Werror` check, adds GHC 8.6.1 support and also filters RTS flags, fixing #5575

(cherry picked from commit e263e8c)
hvr added a commit that referenced this pull request Nov 22, 2018
@hvr
Add -f(no-)error-spans flag to hash-irrelevant flags
152bd62 
This flag is used by the default build-command in `haskell-mode` so
it's very noticeable if haskell-mode causes to recompile the world

NB: no changelog entry as this can be considered a follow-up to #5589

(cherry picked from commit 50be57e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@23Skidoo 23Skidoo 23Skidoo approved these changes

Assignees
No one assigned
Labels
priority: high 🔥
Projects
None yet
Milestone
2.4.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@merijn @23Skidoo @hvr