Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #4383 from Ericson2314/no-legacy-build-dep… #5148

Merged
merged 1 commit into from
Feb 15, 2018

Conversation

23Skidoo
Copy link
Member

@23Skidoo 23Skidoo commented Feb 14, 2018

…ends"

This reverts commit ea75854, reversing
changes made to 602dfdc.

See #5119 for the reason for reverting this.


Please include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • If the change is docs-only, [ci skip] is used to avoid triggering the build bots.

Please also shortly describe how you tested your change. Bonus points for added tests!

@23Skidoo
Copy link
Member Author

23Skidoo commented Feb 14, 2018

Attn. @Ericson2314

Note that this is only for 2.2, the patch is still in master.

@23Skidoo 23Skidoo closed this Feb 14, 2018
@23Skidoo 23Skidoo reopened this Feb 14, 2018
…ends"

This reverts commit ea75854, reversing
changes made to 602dfdc.

See #5119 for the reason for reverting this.
@23Skidoo 23Skidoo merged commit aeebf3e into 2.2 Feb 15, 2018
@23Skidoo 23Skidoo deleted the 2.2-revert-4383 branch February 15, 2018 15:24
@Ericson2314
Copy link
Collaborator

Sounds good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants