Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bootstrap.sh #5127

Merged
merged 1 commit into from
Feb 10, 2018
Merged

Update bootstrap.sh #5127

merged 1 commit into from
Feb 10, 2018

Conversation

angerman
Copy link
Collaborator

@angerman angerman commented Feb 8, 2018

bootstrap should fail on die; and not contiune.

Please include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • If the change is docs-only, [ci skip] is used to avoid triggering the build bots.

Please also shortly describe how you tested your change. Bonus points for added tests!

bootstrap should fail on `die`; and not contiune.
@angerman
Copy link
Collaborator Author

angerman commented Feb 8, 2018

Where do these windows failures come from, all of a sudden?

cd ..\cabal-install
..\cabal test unit-tests --show-details=streaming --test-option=--pattern=!FileMonitor --test-option=--hide-successes
Preprocessing library for cabal-install-2.1.0.0..
Building library for cabal-install-2.1.0.0..
Preprocessing test suite 'unit-tests' for cabal-install-2.1.0.0..
Building test suite 'unit-tests' for cabal-install-2.1.0.0..
Generating manual page dist\build\cabal/cabal.1 ...
Running 1 test suites...
Test suite unit-tests: RUNNING...
File modification time resolution calibration completed, maximum delay
observed: 15.628 ms. Will be using delay of 31.256 for test runs.
Unit Tests
  UnitTests.Distribution.Solver.Modular.Solver
    build-tool-depends
      choose exe after choosing its package - failure:                       FAIL
        tests\UnitTests\Distribution\Solver\Modular\DSL\TestCaseUtils.hs:214:
        Unexpected error:
        Could not resolve dependencies:
        [__0] trying: A-1.0.0 (user goal)
        [__1] trying: A:+flagA
        [__2] next goal: A:B:exe.B (dependency of A)
        [__2] rejecting: A:B:exe.B-1.0.0 (does not contain executable exe2, which is required by A +flagA)
        After searching the rest of the dependency tree exhaustively, these were the goals I've had most trouble fulfilling: A, A:flagA, A:B:exe.B, unknown

@23Skidoo
Copy link
Member

23Skidoo commented Feb 8, 2018

Let's try reverting #5012.

@23Skidoo 23Skidoo merged commit 3b3a8d2 into master Feb 10, 2018
@23Skidoo 23Skidoo deleted the angerman-patch-1 branch February 10, 2018 08:51
@23Skidoo
Copy link
Member

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants