Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround Travis failures (cabal-install-2.0 is broken) #5123

Closed
wants to merge 1 commit into from

Conversation

phadej
Copy link
Collaborator

@phadej phadej commented Feb 7, 2018

See #5120

Please include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • If the change is docs-only, [ci skip] is used to avoid triggering the build bots.

Please also shortly describe how you tested your change. Bonus points for added tests!

@23Skidoo
Copy link
Member

23Skidoo commented Feb 7, 2018

Sure, if this fixes the issue.

@phadej
Copy link
Collaborator Author

phadej commented Feb 7, 2018

Nope. happy has setup-depends: Cabal <2.1 for e.g. happy-1.19.8, so we see:

$ cabal new-build -j2 cabal-install:cabal
In order, the following will be built (use -v for more details):
 - Cabal-2.0.1.1 (lib) (requires download & build)
 - hackage-security-0.5.2.2 (lib) (requires build)
 - happy-1.19.8 (exe:happy) (requires download & build)

which is otherwise incorrect. @hvr proposed that we hardcode into cabal which Cabal know about which GHC and add these (upper) bounds to custom setup-depends.

@angerman angerman mentioned this pull request Feb 9, 2018
4 tasks
@23Skidoo
Copy link
Member

Closing in favour of #5132.

@23Skidoo 23Skidoo closed this Feb 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants