-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Separate GenericPackageDescription from PackageDescription #5100
Conversation
BTW, how do I get pems to cancel AppVeyor build? |
AppVeyor has underdeveloped account structure that doesn't map to GitHub orgs, but I remember that @hvr managed to do it by logging in to AppVeyor using my user name somehow. |
5eaff31
to
ac30a62
Compare
7a40f92
to
854b2fd
Compare
This could maybe use used to clean up PD checking and make it polymorphic on PD and GPD.
Now, neither contains the other, and their common fields are contained in 'CommonPackageDependencies'.
854b2fd
to
b205790
Compare
b205790
to
b3d2220
Compare
@Ericson2314 any thoughts on this PR of yours? Do you still plan to work on it? If not, do you think it'd be worthwhile for someone else to finish it? Or maybe it's not relevant at all anymore, and we should just close? |
@ulysses4ever it has been a long time, but yes I think it might be worthwhile for someone else to complete this. Unless my memory is faulty or something changes over the past few years, our data structures currently do a very bad job of making illegal states unrepresentable. |
This is badly bit-rotted. Let me close, but mark as worth reviving (probably in a new PR, given the state of the patch?). |
Sounds good. |
Now, neither contains the other, and their common fields are contained in 'CommonPackageDependencies'.
I'll probably first merge a change adding lenses per components, so some stuff can be made
{Generic,}PackageDescription
-polymorphic in advance. (The lenses would of course preserve the cond tree structure.)Please include the following checklist in your PR:
[ci skip]
is used to avoid triggering the build bots.Please also shortly describe how you tested your change. Bonus points for added tests!
CC @kmicklas