Have the solver reject packages with a too-new/unsupported spec-version #4909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This compares the request spec-version to the lib:Cabal's version in order to determine whether cabal is able to properly understand the package. If it's newer than the currently linked lib:Cabal version it's turned into a global `FailResult` which the solver treats as desired in terms of backtracking and error reporting. This is related to the new spec-version forward-compat scheme (see haskell#4899). This is a forward-port of haskell#4907 to the `master` branch
Since we now reject unknown spec-versions in the solver, these test-cases were broken; this replaces the 2 occurences by `cabal-version: 2.0` instead. (cherry picked from commit 45c102d)
|
Merged, thanks! |
grayjay
added a commit
to grayjay/cabal
that referenced
this pull request
Dec 3, 2017
haskell#4909 changed the cabal-version of the package under test, so this commit adjusts the versions of the Cabal libraries in the test to be consistent with the cabal-version.
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a forward-port of #4907