Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SetupWrapper: Assume that old Cabals bootstrap. #4787

Merged
merged 1 commit into from
Oct 15, 2017

Conversation

23Skidoo
Copy link
Member

@23Skidoo 23Skidoo commented Sep 22, 2017

See e2bf243#commitcomment-24487898.

Please include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • If the change is docs-only, [ci skip] is used to avoid triggering the build bots.

Please also shortly describe how you tested your change. Bonus points for added tests!

@mention-bot
Copy link

@23Skidoo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dcoutts, @ezyang and @arianvp to be potential reviewers.

23Skidoo referenced this pull request Sep 22, 2017
DanielG added a commit to DanielG/cabal-helper that referenced this pull request Sep 25, 2017
cabal-install 1.24 broke installing older Cabal versions which use
build-type:custom. See haskell/cabal#4787.

This still breaks with HEAD on GHC<8. See
haskell/cabal#4786.
DanielG added a commit to DanielG/cabal-helper that referenced this pull request Sep 25, 2017
cabal-install 1.24 broke installing older Cabal versions which use
build-type:custom. See haskell/cabal#4787.

This still breaks with HEAD on GHC<8. See
haskell/cabal#4786.
@23Skidoo
Copy link
Member Author

Blocked by this strange GHC 8.0.2 failure:

stderr:
--- /home/travis/build/haskell/cabal/cabal-testsuite/PackageTests/NewBuild/T4375/cabal.dist/cabal.out.normalized	2017-09-22 16:41:40.699667452 +0000
+++ /home/travis/build/haskell/cabal/cabal-testsuite/PackageTests/NewBuild/T4375/cabal.dist/cabal.comp.out.normalized	2017-09-22 16:41:40.699667452 +0000
@@ -7,6 +7,7 @@
  - old-locale-1.0.0.7 (lib) (requires download & build)
  - old-time-1.1.0.3 (lib) (requires download & build)
  - a-0.1 (lib:a) (first run)
+writing <ROOT>/cabal.dist/home/.cabal/packages/test-local-repo/old-time/1.1.0.3/old-time-1.1.0.3.tar.gz
 Configuring library for old-locale-1.0.0.7..
 Preprocessing library for old-locale-1.0.0.7..
 Building library for old-locale-1.0.0.7..
*** unexpected failure for PackageTests/NewBuild/T4375/cabal.test.hs

@23Skidoo
Copy link
Member Author

OK, that test runs only when GHC == 8.0.*, which explains why it fails only on that configuration...

@23Skidoo
Copy link
Member Author

23Skidoo commented Sep 26, 2017

writing <ROOT>/cabal.dist/home/.cabal/packages/test-local-repo/old-time/1.1.0.3/old-time-1.1.0.3.tar.gz

What's weird is that that message comes from a call to info, which shouldn't produce marked output...

@23Skidoo
Copy link
Member Author

Failure seems to be intermittent... I think there's a race condition that could be worked around by setting stdout to block buffering and flushing after each hPutStr... or maybe we should just run that test with -j1.

@23Skidoo 23Skidoo merged commit 63f1490 into haskell:master Oct 15, 2017
@23Skidoo 23Skidoo deleted the old-cabals-custom-setup branch October 15, 2017 12:31
@23Skidoo
Copy link
Member Author

Test failure is intermittent and unrelated to the change, see #4376.

@23Skidoo
Copy link
Member Author

Also cherry-picked into 2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants