Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence new -Wmissing-home-modules warning for cabal-install #4535

Merged
merged 1 commit into from
May 24, 2017

Conversation

hvr
Copy link
Member

@hvr hvr commented May 23, 2017

This should hopefully silence all 4 combinations of flag(lib)
and flag(monolithic).

cabal-install.cabal would greatly benefit from common stanzas (#2832)
as it would help reduce the redundancy significantly.

@mention-bot
Copy link

@hvr, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dcoutts, @ezyang and @23Skidoo to be potential reviewers.

@hvr
Copy link
Member Author

hvr commented May 23, 2017

For the record, here's how GHC warned about it:

Preprocessing executable 'cabal' for cabal-install-2.1.0.0..
Building executable 'cabal' for cabal-install-2.1.0.0..

<no location info>: warning: [-Wmissing-home-modules]
    Modules are not listed in command line: Paths_cabal_install
                                            UnitTests.Distribution.Client.ArbitraryInstances
                                            UnitTests.Distribution.Client.FileMonitor
                                            UnitTests.Distribution.Client.GZipUtils
                                            UnitTests.Distribution.Client.Glob
                                            UnitTests.Distribution.Client.IndexUtils.Timestamp
                                            UnitTests.Distribution.Client.InstallPlan
                                            UnitTests.Distribution.Client.JobControl
                                            UnitTests.Distribution.Client.ProjectConfig
                                            UnitTests.Distribution.Client.Sandbox
                                            UnitTests.Distribution.Client.Sandbox.Timestamp
                                            UnitTests.Distribution.Client.Store
                                            UnitTests.Distribution.Client.Tar
                                            UnitTests.Distribution.Client.Targets
                                            UnitTests.Distribution.Client.UserConfig
                                            UnitTests.Distribution.Solver.Modular.Builder
                                            UnitTests.Distribution.Solver.Modular.DSL
                                            UnitTests.Distribution.Solver.Modular.DSL.TestCaseUtils
                                            UnitTests.Distribution.Solver.Modular.MemoryUsage
                                            UnitTests.Distribution.Solver.Modular.QuickCheck
                                            UnitTests.Distribution.Solver.Modular.RetryLog
                                            UnitTests.Distribution.Solver.Modular.Solver
                                            UnitTests.Distribution.Solver.Modular.WeightedPSQ
                                            UnitTests.Options
[ 1 of 29] Compiling IntegrationTests2 ( tests/IntegrationTests2.hs, /stuff3/work/GitHub/cabal/dist-newstyle/build/x86_64-linux/ghc-8.2.0.20170522/cabal-install-2.1.0.0/build/cabal/cabal-tmp/IntegrationTests2.o )

@hvr hvr force-pushed the pr/fix-other-modules branch from 5138286 to 1789c2c Compare May 23, 2017 17:52
@hvr hvr changed the title Silence new -Wmissing-home-modules warning in +monolithic configuration Silence new -Wmissing-home-modules warning for cabal-install May 23, 2017
this should hopefully silence all 4 combinations of flag(lib)
and flag(monolithic).

`cabal-install.cabal` would greatly benefit from common stanzas (haskell#2832)
as it would help reduce the redundancy singnificantly.
@hvr hvr force-pushed the pr/fix-other-modules branch from 1789c2c to e12967c Compare May 23, 2017 18:04
@hvr hvr merged commit e12967c into haskell:master May 24, 2017
@hvr hvr deleted the pr/fix-other-modules branch May 24, 2017 07:14
@hvr
Copy link
Member Author

hvr commented May 24, 2017

One would hope that Travis is clever enough to simply reuse the build report it already had if you push an already validated commit-hash from a single commit PR... :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants