[WIP] Implement External Custom Setup #4055
Conversation
- `custom-setup` can contain `setup-tool` or `setup-depends` - parses both ways - check to make sure both `setup-*` fields aren't give n
|
@Ericson2314, thanks for your PR! By analyzing the history of the files in this pull request, we identified @phadej, @ezyang and @dcoutts to be potential reviewers. |
Ericson2314
changed the title
Ericson2314
changed the title
|
|
||
| parse = do name <- parse | ||
| _ <- Parse.char ':' | ||
| exe <- Parse.munch1 isAlphaNum |
There was a problem hiding this comment.
I think the executable name format is more flexible than AlphaNum. Safest is to parse as if it were a PackageName.
| parsec = do | ||
| name <- lexemeParsec | ||
| _ <- P.char ':' | ||
| exe <- P.munch1 isAlphaNum |
There was a problem hiding this comment.
Don't forget to update here too when you're done.
| (x, "") -> x | ||
| (x, y) -> error "Ambiguous values for test field: '" | ||
| where combine field = field a `mappend` field b | ||
| combine' field = case ( unUnqualComponentName $ field a |
There was a problem hiding this comment.
I'd much prefer it if you could add a function like "isNullUnqualComponentName" to factor this type of test. It would be more efficient too since unUnqualComponentName requires serializing to String.
|
@Ericson2314 Should we close this PR for now? |
|
Sure. It will look completely different rebased, and the point won't be external custom setups anyways. |
Implementation of #4047