Do an early check for unbuildable deps, and give good error. #4023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezyang
force-pushed
the
pr/T3978
branch
2 times, most recently
from
58d194e to
e80207c
Compare
When a library/executable is unbuildable, the solver may still return a reference to it. Handle this gracefully in ProjectPlanning with a nice error message, rather than an assert failure. Fixes haskell#3978. Signed-off-by: Edward Z. Yang <[email protected]>
|
LGTM. Took the liberty of just merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a library/executable is unbuildable, the solver may still
return a reference to it. Handle this gracefully in ProjectPlanning
with a nice error message, rather than an assert failure.
Fixes #3978.
Signed-off-by: Edward Z. Yang [email protected]