Revert "Generalize HookedBuildInfo to work with any type of component." #3627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezyang
force-pushed
the
cabal-convenience-bc
branch
3 times, most recently
from
5ba256f to
396c337
Compare
This reverts commit af7bb53, restoring 'HookedBuildInfo' backwards compatibility.
ezyang
force-pushed
the
cabal-convenience-bc
branch
from
396c337 to
262933f
Compare
|
Context: #3626, ekmett/bytes#31. Since this is only a problem with HEAD (future 2.0), do we really need to revert it? |
|
I don't think we should apply this BC-breaking change unless the rest of hooks gets redesigned. There's been muttering about it but I don't see any code. (Fortunately it's pretty easy to revert this revert.) |
|
OK. |
This was referenced Jul 28, 2016
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit af7bb53,
restoring 'HookedBuildInfo' backwards compatibility.