Generalise 'AllowNewer'-types' names #3476
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| data AllowNewerDep = AllowNewerDep PackageName | ||
| | AllowNewerDepScoped PackageName PackageName | ||
| data RelaxedDep = RelaxedDep PackageName | ||
| | RelaxedDepScoped PackageName PackageName |
This also adds a not yet used `AllowOlder` newtype This is a preparatory refactoring propsed in haskell#3466 for supporting `--allow-older`
|
@hvr Haven't reviewed all changes in detail, but fine with me in principle. |
| @@ -263,63 +264,87 @@ instance Semigroup GlobalFlags where | |||
| -- 'build-depends: array >= 0.3 && < 0.5', are we allowed to relax the upper | |||
| -- bound and choose a version of 'array' that is greater or equal to 0.5? By | |||
| -- default the upper bounds are always strictly honored. | |||
| data AllowNewer = | |||
| data RelaxDeps = | |||
|
|
|||
| -- | Default: honor the upper bounds in all dependencies, never choose | |||
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds a not yet used
AllowOldernewtypeThis is a preparatory refactoring propsed in #3466 for supporting
--allow-older