Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time different blocks of travis script #3469

Merged
merged 1 commit into from
Jun 2, 2016

Conversation

phadej
Copy link
Collaborator

@phadej phadej commented May 30, 2016

Makes easier to reason how to address #3465

@phadej phadej force-pushed the travis-script-time branch 2 times, most recently from 29ab899 to 205e8d8 Compare May 30, 2016 14:07
@phadej phadej changed the title WIP: Add timings to travis script Time different blocks of travis script May 30, 2016
@phadej phadej force-pushed the travis-script-time branch from 205e8d8 to e581f75 Compare May 30, 2016 15:05
@ezyang
Copy link
Contributor

ezyang commented May 30, 2016

Great; I would champion a PR for this.

On May 30, 2016 8:45:59 AM GMT-05:00, Oleg Grenrus [email protected] wrote:

You can view, comment on, or merge this pull request online at:

#3469

-- Commit Summary --

  • WIP

-- File Changes --

M travis-script.sh (83)

-- Patch Links --

https://github.com/haskell/cabal/pull/3469.patch
https://github.com/haskell/cabal/pull/3469.diff


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#3469

Sent from my Android device with K-9 Mail. Please excuse my brevity.

# Bootstrap cabal, to verify bootstrap.sh script works.
# ---------------------------------------------------------------------

OLD_CWD=$PWD
bootstrap() {
OLD_CWD=$PWD
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might it be a better idea to use subshells to ensure the preservation of CWD?

(I mean, the build will certainly fail if it isn't restored properly, but...)

@BardurArantsson
Copy link
Collaborator

I think it's a matter of pressing the "Merge" button? (One very minor comment, though. Not something that necessarily needs to changed)

@BardurArantsson BardurArantsson merged commit dd18cd9 into haskell:master Jun 2, 2016
@BardurArantsson
Copy link
Collaborator

BardurArantsson commented Jun 2, 2016

Apologies if I overstepped any boundaries by merging this. LGTM, etc. and I think we should be actively investing into getting more self-insight (as it were).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants