Add a regression test for issue #3324 #3432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| expectBuildFailed failure | ||
|
|
||
| -- add the missing dep, now it should work | ||
| appendFile (basedir </> testdir </> "q" </> "q.cabal") |
There was a problem hiding this comment.
I think you need to add a finally block restoring the q.cabal file to its original state, otherwise the test suite is not idempotent.
There was a problem hiding this comment.
You're quite right.
|
@23Skidoo not sure why it didn't fail on travis, it fails for me as expected. |
|
Looks like we were not running |
|
And now both build bots are broken. |
Use base not haskell2010 package.
|
@23Skidoo this ought to fix it. Let's see... |
|
@23Skidoo took the liberty to merge, since it fixes the build on master (and I'd addressed the review comments ok I think). |
|
@dcoutts Great, thanks. |
ekmett
added a commit
to ekmett/bound
that referenced
this pull request
Jul 25, 2016
ekmett
added a commit
to ekmett/bound
that referenced
this pull request
Aug 11, 2016
Revert "Hack to work with cabal HEAD in spite of haskell/cabal#3432"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.