Turn 'configPrograms' field into a 'Last'-monoid #3195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvr
force-pushed
the
pr/configprograms-last
branch
2 times, most recently
from
040ac42 to
c9e08f9
Compare
|
Still fails (on < 7.6): |
|
@23Skidoo that one's weird... I'm investigating... |
This implements the suggestions mentioned at haskell#3169 (comment) The main benefit of this change is turning 'ConfigFlags' into a uniform product-type suitable for generic derivation of pointwise `Semigroup`/`Monoid` instances. NB: This changes the `Binary` serialisation of `ConfigFlags` since there's now an additional `Maybe` inserted in `configPrograms`'s type
hvr
force-pushed
the
pr/configprograms-last
branch
from
c9e08f9 to
62c3aa6
Compare
|
@23Skidoo I'm quite optimistic the builds will work this time... |
| @@ -404,7 +404,7 @@ configAbsolutePaths f = | |||
|
|
|||
| defaultConfigFlags :: ProgramConfiguration -> ConfigFlags | |||
| defaultConfigFlags progConf = emptyConfigFlags { | |||
| configPrograms = progConf, | |||
| configPrograms = pure progConf, | |||
There was a problem hiding this comment.
Last' progConf would be more readable IMO.
23Skidoo
added a commit
that referenced
this pull request
Feb 27, 2016
Turn 'configPrograms' field into a 'Last'-monoid
|
Merged, thanks! I'll need to check whether this patch breaks any setup scripts before it can be cherry-picked into 1.24 as well ( |
|
Yes, I don't think it does, but it never hurts to double-check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the suggestions mentioned at
#3169 (comment)
The main benefit of this change is turning 'ConfigFlags' into a uniform
product-type suitable for generic derivation of pointwise
Semigroup/Monoidinstances.NB: This changes the
Binaryserialisation ofConfigFlagssince there'snow an additional
Maybeinserted inconfigPrograms's type