Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to '--allow-newer' #3165

Merged
merged 7 commits into from
Feb 19, 2016
Merged

Conversation

23Skidoo
Copy link
Member

Two improvements:

Split the 'onAllBuildDepends' function in three parts and move it to
'Distribution.PackageDescription.Configuration'.
@23Skidoo
Copy link
Member Author

/cc @dcoutts

@23Skidoo 23Skidoo force-pushed the allow-newer-cabal branch 2 times, most recently from e5df155 to 57c415e Compare February 19, 2016 01:40
* Fix parsing of '--allow-newer=foo --allow-newer=bar'.
* Fix './Setup configure --allow-newer --enable-{tests, benchmarks}'.
@snoyberg
Copy link
Collaborator

Thank you @23Skidoo!

@dcoutts
Copy link
Contributor

dcoutts commented Feb 19, 2016

Looks fine. Providing --allow-newer as a Setup configure option is ok given that some tools cannot or will not use the full --exact-configuration. And yes it's right that --allow-newer is ignored if --exact-configuration is given.

23Skidoo added a commit that referenced this pull request Feb 19, 2016
@23Skidoo 23Skidoo merged commit 1eaf2ee into haskell:master Feb 19, 2016
@23Skidoo 23Skidoo deleted the allow-newer-cabal branch February 19, 2016 12:53
23Skidoo added a commit to 23Skidoo/cabal that referenced this pull request Feb 19, 2016
23Skidoo added a commit to 23Skidoo/cabal that referenced this pull request Feb 20, 2016
garetxe pushed a commit to garetxe/cabal that referenced this pull request Mar 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants