Fix space leak in ./Setup configure #3076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis failure is unrelated to your change (see #3003). |
|
Incidentally, git-annex HEAD is down to 16 flags; see shy jo |
|
LGTM, merging. Sorry for taking so long! |
23Skidoo
added a commit
that referenced
this pull request
Jan 26, 2016
Fix space leak in ./Setup configure
This was referenced Jan 26, 2016
|
@23Skidoo No problem. Thanks for merging it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the space leak in #2777 without modifying the logic for choosing flags. It is a lot simpler than #2925, though I think an improvement to the algorithm like in #2925 is still needed. I tested the practicality of solving for more flags by running
./Setup configureon git-annex with 3 of the 21 flags removed. Most of the dependencies were missing, which meant that Setup had to try all 2^18 flag combinations. It took 13 minutes./cc @joeyh