-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SavedConfig Monoid instance: make list fields work like Flags. #2226
Conversation
See #2221 for an alternative approach. |
Fixes haskell#1884. See code comments for more details.
5512317
to
7e744fe
Compare
After a discussion with @dcoutts we decided to merge this for the time being, but migrate to an include/include with filtering mechanism in the future. |
SavedConfig Monoid instance: make list fields work like Flags.
W00t! Do you want me to send PRs for 1.18 and 1.20? |
I would really appreciate if we could. I still recommend 1.18 to most people so as to avoid having two different versions of the Cabal library on their systems. (I still regularly run into error messages about conflicting Cabal library versions if I use parallel builds.) |
Do we have a ticket for this? |
It was issue #1244. I hadn't noticed that the issue had been closed; I'm still able to reproduce it in some cases. It may be that this issue was resolved with cabal-install-1.20; with 1.18 I can reproduce (which seems contrary to what #1244 says):
I believe I've also reproduced this when just using a single version of cabal-install, but I was not able to reproduce that right now. |
Hmm, can it be the case that |
No, they're both using the same version of GHC (ghc-7.8). I believe that error message is simply referring to the version of the compiler which was used to compile cabal-install itself. |
Hmm, yes looks like you're right.
I thought a bit more about this: it looks like the error is caused by One approach to making these errors happen less often is to make |
Fixes #1884. See code comments for more details.