-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cabal repl handling of Ctrl-C #1535
Conversation
I think that this a fine workaround, but it'd be nice to fix the issue in |
We should do both, fix process and merge this workaround. @23Skidoo if the code looks fine to you feel free to merge. |
Fix cabal repl handling of Ctrl-C
Awesome. Any chance to get this in a bug fix release on Hackage? |
That's up to @tibbe. |
Broken by haskell#1535.
Broken by haskell#1535.
@23Skidoo You're right. I didn't test on windows. Sorry about that. Things got merged a) quicker than I had time to update them b) quicker than I expected :) I was hoping to switch to Thanks for merging this and fixing up the windows stuff! |
Nice. Improvements welcome, of course. |
The code here does fix #1448, but since it "borrows" code directly from the process package this may not be the best way to fix it. See for example, http://ghc.haskell.org/trac/ghc/ticket/8419.
Please let me know if I need to change anything so that we can squash this C-c handling bug :)