-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Point out validate.sh
more prominently in CONTRIBUTING.md
#10330
Point out validate.sh
more prominently in CONTRIBUTING.md
#10330
Conversation
Pointing that Adding a sentence or a paragraph feels better. Something like “You can also run all tests locally using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to Francesco's point: I think it's good enough. But if someone feels strong about it, they should feel free to "request changes".
It might be worth pointing out that, especially with the |
Yes, my suggestion is to:
This way we should be clear and immediate enough for all use cases. |
93a4657
to
6c2b6c3
Compare
I've addressed comments & made the headings uniform. (Use the rich diff to see changes.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very good
6c2b6c3
to
1d57a33
Compare
The
CONTRIBUTING.md
makes it sound really hard to run tests locally, but actuallyvalidate.sh
works fine!validate.sh
still needs work (see the list in #10320) for example, but it's a great starting point.