Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable Windows CI #10282

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Re-enable Windows CI #10282

merged 1 commit into from
Sep 2, 2024

Conversation

jasagredo
Copy link
Collaborator

@jasagredo jasagredo commented Aug 26, 2024 •
edited
Loading

This PR disables the 9.0.2 validate job for Windows and provides --io-manager=native for every other GHC. See #9571 for the reasons.

@jasagredo jasagredo force-pushed the js/investigate-windows branch 6 times, most recently from 38d80da to d7d1548 Compare August 28, 2024 07:46
@jasagredo jasagredo mentioned this pull request Aug 28, 2024
Closed
@jasagredo jasagredo force-pushed the js/investigate-windows branch from 0e1a187 to dee8a63 Compare August 28, 2024 11:46
@jasagredo jasagredo changed the title DO NOT MERGE: Investigate Windows CI Re-enable Windows CI Aug 28, 2024
@jasagredo jasagredo force-pushed the js/investigate-windows branch from dee8a63 to 6eb259b Compare August 28, 2024 11:49
@ulysses4ever
Copy link
Collaborator

See #9571 for the reasons.

I looked there but couldn't connect your last comment there and this PR.

Mikolaj
Mikolaj approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ulysses4ever
ulysses4ever approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see now that you made a great summary on Matrix:

I have a proposal for the CI Windows issues. It turns out that enabling io-manager=native for Windows makes all tests pass for all exercised GHCs except 9.0.2 which crashes with an access violation.

However not enabling the io-manager results in random GHCs failing with fd: hGetLine: end of input exceptions.

My proposal is to disable the 9.0.2 validate job for Windows and enable io-manager=native for all other GHCs. We are already disabling 8.10.7 and 8.8.4 on Windows.

That works, I guess. Although this practically means that we aren't really delivering on that 5-year support window...

@jasagredo jasagredo added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Aug 28, 2024
@mergify mergify bot added the ready and waiting Mergify is waiting out the cooldown period label Aug 28, 2024
@geekosaur geekosaur mentioned this pull request Aug 28, 2024
Merged
@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Aug 30, 2024
@Mikolaj Mikolaj force-pushed the js/investigate-windows branch from 6eb259b to 7f0ce61 Compare August 30, 2024 14:54
geekosaur pushed a commit that referenced this pull request Aug 31, 2024
@jasagredo @geekosaur
Re-enable Windows CI
62658bc 
Cherry-picked from #10282 so CI will pass.
geekosaur pushed a commit that referenced this pull request Aug 31, 2024
@jasagredo @geekosaur
Re-enable Windows CI
0e119ce 
Cherry-picked from #10282 so CI will pass.
@geekosaur
Copy link
Collaborator

Can we do something stupid like wrapping ghci with something that always exits successfully?

@jasagredo jasagredo force-pushed the js/investigate-windows branch 3 times, most recently from 9c2d14d to 4aade2d Compare September 1, 2024 22:07
@mergify mergify bot merged commit 474d698 into haskell:master Sep 2, 2024
49 checks passed
@geekosaur
Copy link
Collaborator

@mergify backport 3.12

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 2, 2024 •
edited
Loading

backport 3.12

✅ Backports have been created

@mergify mergify bot mentioned this pull request Sep 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulysses4ever ulysses4ever ulysses4ever approved these changes

@geekosaur geekosaur geekosaur approved these changes

@Mikolaj Mikolaj Mikolaj approved these changes

Assignees
No one assigned
Labels
continuous-integration merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge platform: windows ready and waiting Mergify is waiting out the cooldown period
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jasagredo @ulysses4ever @geekosaur @Mikolaj