CI: skip cli-suite on Windows due to #9571 #10257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasagredo
approved these changes
Aug 13, 2024
ulysses4ever
added
squash+merge me
|
If no one objects, I propose to merge it skipping the 2-day delay. Once we get the two approvals of course. |
geekosaur
requested changes
Aug 13, 2024
| @@ -210,6 +210,7 @@ jobs: | |||
| run: sh validate.sh $FLAGS -s cli-tests | |||
|
|
|||
| - name: Validate cli-suite | |||
| if: runner.os != 'Windows' | |||
There was a problem hiding this comment.
See line 177 for how to do this properly; I think that won't work as is (runner.os won't be expanded).
There was a problem hiding this comment.
Okay, actually it looks like it did work (skipped cli-suite only on Windows) but we probably want to be consistent.
There was a problem hiding this comment.
Line 177 is a part of a bash expression, and I act on the yaml level. So, I'm not sure why they should be consistent necessarily: they're pretty different notations...
geekosaur
approved these changes
Aug 13, 2024
|
Do we want to backport this / will this affect CI on 3.12 branch? |
|
@mergify backport 3.12 |
✅ Backports have been created
|
2 tasks
geekosaur
pushed a commit
that referenced
this pull request
Sep 13, 2024
mergify bot
added a commit
that referenced
this pull request
Sep 13, 2024
…10305) * hackage-tests: Add --index-state argument to fix the cabal files We need to fix the index-state we test against so a new bad cabal file doesn't take down the CI for everyone. Towards #10284 (cherry picked from commit 8e4d167) * ci: Fix --index-state for hackage roundtrip tests As a principle, tests which are required for CI to pass should be reproducible and not depending on external resources changes or being modified. The hackage tests currently violate this by depending on the latest index state from hackage. This is problematic because until the test is fixed all merges into master are blocked. Even though the patches in question have nothing to do with the test. It would be more suitable for a nightly job to run on the latest index and for normal CI to run with a fixed index which is updated periodically in a controlled manner. Fixes #10284 (cherry picked from commit 31507b1) * Re-enable Windows CI (cherry picked from commit 4aade2d) * CI: skip cli-suite on Windows due to #9571 (#10257) (cherry picked from commit 30d2a38) --------- Co-authored-by: Matthew Pickering <[email protected]> Co-authored-by: Javier Sagredo <[email protected]> Co-authored-by: Artem Pelenitsyn <[email protected]>
erikd
pushed a commit
to erikd/cabal
that referenced
this pull request
Jan 9, 2025
erikd
pushed a commit
to erikd/cabal
that referenced
this pull request
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further investigation of #9571 is needed, but we can take a breathe in the meantime.
Template B: This PR does not modify behaviour or interface
E.g. the PR only touches documentation or tests, does refactorings, etc.
Include the following checklist in your PR: