Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cabal install silently ignores --enable-profiling flags. #8529

Closed
AndreasPK opened this issue Oct 13, 2022 · 3 comments
Closed

cabal install silently ignores --enable-profiling flags. #8529

AndreasPK opened this issue Oct 13, 2022 · 3 comments
Assignees
@alt-romes
Labels
attention: pr-welcome cabal-install: cmd/install type: bug

Comments

@AndreasPK
Copy link
Collaborator

TLDR

Installing a profiled version of an executable seems to be not supported.

Instead cabal seems to silently swallow the flag.

To Reproduce

This does install a non-profiled version of the executable.

andi@horzube:~$ cabal install hasktags --enable-executable-profiling --overwrite-policy=always --enable-profiling
Warning: this is a debug build of cabal-install with assertions enabled.
Resolving dependencies...
Up to date
Warning: installdir is not defined. Set it in your cabal config file or use
--installdir=<path>. Using default installdir: "/home/andi/.cabal/bin"
Symlinking 'hasktags' to '/home/andi/.cabal/bin/hasktags'
andi@horzube:~$ hasktags +RTS -p
hasktags: the flag -p requires the program to be built with -prof
hasktags:

I can build a profiled version of a package by running cabal build and copying over, but that seems unneccesary.

Expected behavior

I would have expected cabal to install a profiled version of the program if I ask it to. In absence of that I would at least expect it to complain about the flag being ignored/incompatible with install.

But I don't think there is a good reason to have profiling not work with the install command.

System information

  • Operating system: Debian
  • cabal, ghc versions: HEAD/9.4.2

Additional context
Add any other context about the problem here.
@Mikolaj
Copy link
Member

Mikolaj commented Oct 13, 2022

Indeed, cabal install ignores some flags (e.g., #7236). I didn't know about this one. Thank you for the report.

@alt-romes alt-romes self-assigned this Feb 6, 2024
@alt-romes
Copy link
Collaborator

This should be fixed by #9697.

alt-romes added a commit to alt-romes/cabal that referenced this issue Feb 6, 2024
@alt-romes
Apply local configuration to install targets
129946d 
The target of `cabal install` is not considered to be a local package,
which means local configuration (e.g. in cabal.project, or flags like
--enable-profiling) does not apply to it.

In 76670eb, we changed the behaviour to
applying the local flags to cabal install targets, but it used the
literal target string as a package name to which the flags were
additionally applied.

However, `cabal install` targets are NOT necessarily package names, so,
e.g., if we did `cabal install exe:mycomp`, the local flags would not
apply since "exe:mycomp" is not a recognized /package/.

The solution is to parse the target selectors first, and apply the local
flags to the package of the resolved targets.

Fixes haskell#7297, haskell#8909, the install part of haskell#7236, haskell#8529, haskell#7832
@alt-romes alt-romes mentioned this issue Feb 6, 2024
Merged
alt-romes added a commit to alt-romes/cabal that referenced this issue Feb 6, 2024
@alt-romes
Apply local configuration to install targets
922ef7f 
The target of `cabal install` is not considered to be a local package,
which means local configuration (e.g. in cabal.project, or flags like
--enable-profiling) does not apply to it.

In 76670eb, we changed the behaviour to
applying the local flags to cabal install targets, but it used the
literal target string as a package name to which the flags were
additionally applied.

However, `cabal install` targets are NOT necessarily package names, so,
e.g., if we did `cabal install exe:mycomp`, the local flags would not
apply since "exe:mycomp" is not a recognized /package/.

The solution is to parse the target selectors first, and apply the local
flags to the package of the resolved targets.

Fixes haskell#7297, haskell#8909, the install part of haskell#7236, haskell#8529, haskell#7832
mpickering pushed a commit to alt-romes/cabal that referenced this issue Feb 6, 2024
@alt-romes @mpickering
Apply local configuration to install targets
25e1283 
The target of `cabal install` is not considered to be a local package,
which means local configuration (e.g. in cabal.project, or flags like
--enable-profiling) does not apply to it.

In 76670eb, we changed the behaviour to
applying the local flags to cabal install targets, but it used the
literal target string as a package name to which the flags were
additionally applied.

However, `cabal install` targets are NOT necessarily package names, so,
e.g., if we did `cabal install exe:mycomp`, the local flags would not
apply since "exe:mycomp" is not a recognized /package/.

The solution is to parse the target selectors first, and apply the local
flags to the package of the resolved targets.

Fixes haskell#7297, haskell#8909, the install part of haskell#7236, haskell#8529, haskell#7832
Mikolaj pushed a commit to alt-romes/cabal that referenced this issue Feb 9, 2024
@alt-romes @Mikolaj
Apply local configuration to install targets
aa592c3 
The target of `cabal install` is not considered to be a local package,
which means local configuration (e.g. in cabal.project, or flags like
--enable-profiling) does not apply to it.

In 76670eb, we changed the behaviour to
applying the local flags to cabal install targets, but it used the
literal target string as a package name to which the flags were
additionally applied.

However, `cabal install` targets are NOT necessarily package names, so,
e.g., if we did `cabal install exe:mycomp`, the local flags would not
apply since "exe:mycomp" is not a recognized /package/.

The solution is to parse the target selectors first, and apply the local
flags to the package of the resolved targets.

Fixes haskell#7297, haskell#8909, the install part of haskell#7236, haskell#8529, haskell#7832
alt-romes added a commit to alt-romes/cabal that referenced this issue Feb 9, 2024
@alt-romes
Apply local configuration to install targets
811e7d8 
The target of `cabal install` is not considered to be a local package,
which means local configuration (e.g. in cabal.project, or flags like
--enable-profiling) does not apply to it.

In 76670eb, we changed the behaviour to
applying the local flags to cabal install targets, but it used the
literal target string as a package name to which the flags were
additionally applied.

However, `cabal install` targets are NOT necessarily package names, so,
e.g., if we did `cabal install exe:mycomp`, the local flags would not
apply since "exe:mycomp" is not a recognized /package/.

The solution is to parse the target selectors first, and apply the local
flags to the package of the resolved targets.

Fixes haskell#7297, haskell#8909, the install part of haskell#7236, haskell#8529, haskell#7832
alt-romes added a commit to alt-romes/cabal that referenced this issue Feb 9, 2024
@alt-romes
Apply local configuration to install targets
802a326 
The target of `cabal install` is not considered to be a local package,
which means local configuration (e.g. in cabal.project, or flags like
--enable-profiling) does not apply to it.

In 76670eb, we changed the behaviour to
applying the local flags to cabal install targets, but it used the
literal target string as a package name to which the flags were
additionally applied.

However, `cabal install` targets are NOT necessarily package names, so,
e.g., if we did `cabal install exe:mycomp`, the local flags would not
apply since "exe:mycomp" is not a recognized /package/.

The solution is to parse the target selectors first, and apply the local
flags to the package of the resolved targets.

Fixes haskell#7297, haskell#8909, the install part of haskell#7236, haskell#8529, haskell#7832
@alt-romes
Copy link
Collaborator

Fixed by #9697

erikd pushed a commit to erikd/cabal that referenced this issue Apr 22, 2024
@alt-romes @erikd
Apply local configuration to install targets
745a052 
The target of `cabal install` is not considered to be a local package,
which means local configuration (e.g. in cabal.project, or flags like
--enable-profiling) does not apply to it.

In 76670eb, we changed the behaviour to
applying the local flags to cabal install targets, but it used the
literal target string as a package name to which the flags were
additionally applied.

However, `cabal install` targets are NOT necessarily package names, so,
e.g., if we did `cabal install exe:mycomp`, the local flags would not
apply since "exe:mycomp" is not a recognized /package/.

The solution is to parse the target selectors first, and apply the local
flags to the package of the resolved targets.

Fixes haskell#7297, haskell#8909, the install part of haskell#7236, haskell#8529, haskell#7832
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alt-romes alt-romes

Labels
attention: pr-welcome cabal-install: cmd/install type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Mikolaj @AndreasPK @alt-romes