Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"To use ... the package needs to specify at least 'cabal-version: >= 1.18'" ◀ should drop >= #7088

Closed
juhp opened this issue Sep 24, 2020 · 0 comments · Fixed by #8205
Closed

Comments

@juhp
Copy link
Collaborator

juhp commented Sep 24, 2020

Describe the bug
If I have:

cabal-version: 1.10

cabal check complains

Warning: To use the 'extra-doc-files' field the package needs to specify at
least 'cabal-version: >= 1.18'.
Warning: Hackage would reject this package.

After changing to cabal-version: >= 1.18 it then complains:

Warning: Packages relying on Cabal 1.12 or later should specify a specific
version of the Cabal spec of the form 'cabal-version: x.y'. Use
'cabal-version: 1.18'.

Okay, apparently Hackage would not reject cabal-version: >= 1.18,
but this is annoying, it should just suggest cabal-version: 1.18 to the user in the first place.

System information

  • cabal-install 3.2 (but this is true for all recent releases in memory: 2.x etc)

Additional info
Seems it is determined in Cabal/src/Distribution/PackageDescription/Check.hs

@juhp juhp changed the title "To use ... the package needs to specify at least 'cabal-version: >= 1.18'" <<== should be just 1.18 "To use ... the package needs to specify at least 'cabal-version: >= 1.18'" ◀ should drop >= Sep 24, 2020
It-Is-Jeremy pushed a commit to It-Is-Jeremy/cabal that referenced this issue Oct 8, 2020
It-Is-Jeremy pushed a commit to It-Is-Jeremy/cabal that referenced this issue Oct 8, 2020
Update version warnings as per review in haskell#7104.

resolves: haskell#7088
@gbaz gbaz added the type: bug label Aug 28, 2021
ulysses4ever pushed a commit to ulysses4ever/cabal that referenced this issue Jun 10, 2022
ulysses4ever pushed a commit to ulysses4ever/cabal that referenced this issue Jun 10, 2022
Update version warnings as per review in haskell#7104.

resolves: haskell#7088
ulysses4ever added a commit to ulysses4ever/cabal that referenced this issue Jun 10, 2022
Co-authored-by:    Jeremy Scott <[email protected]>
Co-authored-by:    Artem Pelenitsyn <[email protected]>
ulysses4ever added a commit to ulysses4ever/cabal that referenced this issue Jun 10, 2022
Co-authored-by:    Jeremy Scott <[email protected]>
Co-authored-by:    Artem Pelenitsyn <[email protected]>
ulysses4ever added a commit to ulysses4ever/cabal that referenced this issue Jun 11, 2022
Co-authored-by: Jeremy Scott <[email protected]>
Co-authored-by: Artem Pelenitsyn <[email protected]>
Co-authored-by: Francesco Gazzetta <[email protected]>
@mergify mergify bot closed this as completed in #8205 Jun 11, 2022
GuillaumeGen pushed a commit to tweag/cabal that referenced this issue Jun 17, 2022
Co-authored-by: Jeremy Scott <[email protected]>
Co-authored-by: Artem Pelenitsyn <[email protected]>
Co-authored-by: Francesco Gazzetta <[email protected]>
mergify bot pushed a commit that referenced this issue Jul 8, 2022
Co-authored-by: Jeremy Scott <[email protected]>
Co-authored-by: Artem Pelenitsyn <[email protected]>
Co-authored-by: Francesco Gazzetta <[email protected]>
(cherry picked from commit e944b70)
andreabedini pushed a commit that referenced this issue Jul 8, 2022
Co-authored-by: Jeremy Scott <[email protected]>
Co-authored-by: Artem Pelenitsyn <[email protected]>
Co-authored-by: Francesco Gazzetta <[email protected]>
(cherry picked from commit e944b70)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants