Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

master fails because not always there are plusses in flags: #6853

Closed
phadej opened this issue May 27, 2020 · 2 comments
Closed

master fails because not always there are plusses in flags: #6853

phadej opened this issue May 27, 2020 · 2 comments
Milestone
3.4.0.0-rc1

Comments

@phadej
Copy link
Collaborator

phadej commented May 27, 2020

cabal.project

constraints: simple-sendfile +allow-bsd

error

Invalid flag assignment: allow-bsd
CallStack (from HasCallStack):
  error, called at ./Distribution/ReadE.hs:42:24 in Cabal-3.3.0.0-BuS0aoNOUxNGwNITn6L7bR:Distribution.ReadE
@phadej
Copy link
Collaborator Author

phadej commented May 29, 2020

Fixed in #6854

phadej added a commit to phadej/cabal that referenced this issue May 29, 2020
@phadej
Add test for haskell#6853
0140342 
It's import that flag is *True*, so it's passed without prefix-sign.
phadej added a commit that referenced this issue May 29, 2020
@phadej
Merge pull request #6858 from phadej/6853-test
36ab7a0 
Add test for #6853
@phadej
Copy link
Collaborator Author

phadej commented Jun 2, 2020

Resolved by #6853 (fix) and #6858 (regression test).

@phadej phadej closed this as completed Jun 2, 2020
@phadej phadej mentioned this issue Jul 10, 2020
Merged
@phadej phadej added this to the 3.4.0.0-rc1 milestone Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4.0.0-rc1
Development

No branches or pull requests
1 participant
@phadej