Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a default-language optional in cabal-version: 3.2 #6288

Closed
phadej opened this issue Oct 6, 2019 · 4 comments
Closed

Make a default-language optional in cabal-version: 3.2 #6288

phadej opened this issue Oct 6, 2019 · 4 comments
Milestone

Comments

@phadej
Copy link
Collaborator

phadej commented Oct 6, 2019

It's essentially always Haskell2010 nowadays.

We can introduce the same Default thing as we did with build-type

👍 / 👎 ?

@hvr
Copy link
Member

hvr commented Oct 7, 2019

I've been wanting to do this as well; the only thing we need however is to make sure that there's a way to not send any -XHaskell2010 or -XHaskell98 at all to GHC (e.g. via an empty default-language: ?), i.e. to explicitly select GHC's default mode... or maybe we don't need that?

@phadej
Copy link
Collaborator Author

phadej commented Oct 7, 2019 via email

@23Skidoo
Copy link
Member

23Skidoo commented Feb 7, 2020

SGTM.

@emilypi
Copy link
Member

emilypi commented May 8, 2020

+1

phadej added a commit to phadej/cabal that referenced this issue Jun 22, 2020
phadej added a commit to phadej/cabal that referenced this issue Jun 22, 2020
phadej added a commit that referenced this issue Jun 22, 2020
Add check tests for default-language (#6288)
phadej added a commit to phadej/cabal that referenced this issue Jun 22, 2020
- Add availableSince to language/extension fields
   - Also autogen-modules once we are on that.
- Remove default-language check for cabal-version: 3.4

We cannot make the field `uniqueFieldAlaDef`, as that would require
specifying `default-language` in each subconditional.
I leave it for haskell#6925

Note: the default language is whatever is the compiler's default.
The GHC-8.10 default is its variant of Haskell2010
with NondecreasingIndentation and without DatatypeContexts
@phadej phadej closed this as completed in e42e546 Jun 23, 2020
@phadej phadej added this to the 3.4.0.0-rc1 milestone Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants