Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstall (to add profiling) of libraries with C dependencies no longer possible #3128

Closed
jacobstanley opened this issue Feb 9, 2016 · 5 comments

Comments

@jacobstanley
Copy link

With cabal-install-1.22.4.0 I am able to rebuild/reinstall a package in place in order to enable profiling, but without having to build all the *.o files again.

Attempting this with cabal-install-1.22.7.0 gives an error like this for the text package:

ar: dist/dist-sandbox-5f5bc1e1/build/cbits/cbits.p_o: No such file or directory

A quick look through the commits between these releases shows that eb46872 looks somewhat suspicious.

I have not yet verified if this happens on master.

@23Skidoo
Copy link
Member

/cc @lukexi

@lukexi
Copy link
Collaborator

lukexi commented Feb 10, 2016

On it! Thanks for the cc

@lukexi
Copy link
Collaborator

lukexi commented Feb 11, 2016

Hi @jystic — I put a patch here for testing lukexi@ac14bdb.

Tested successfully with:

cabal get text
cd text-1.2.2.0
cabal configure --disable-library-profiling
cabal build
cabal configure --enable-library-profiling 
cabal build

23Skidoo pushed a commit that referenced this issue Feb 13, 2016
@23Skidoo
Copy link
Member

@lukexi Confirmed that your fix works, pushed it to master and 1.22. Can you please also add a test case to Cabal's PackageTests suite?

@jacobstanley
Copy link
Author

💯 thanks for the quick response @lukexi @23Skidoo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants