Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Haddock 0.x support #1718

Closed
Fuuzetsu opened this issue Mar 9, 2014 · 2 comments
Closed

Drop Haddock 0.x support #1718

Fuuzetsu opened this issue Mar 9, 2014 · 2 comments
Labels
cabal-install: cmd/haddock type: enhancement type: refactor
Milestone
⊥

Comments

@Fuuzetsu
Copy link
Member

Fuuzetsu commented Mar 9, 2014

Module comment in Cabal.Distribution.Simple.Haddock says that the module supports 0.x and 2.x Haddock versions. Perhaps it'd be a good idea to drop 0.x support to simplify the module.

I doubt that there's a compiler version that compiles today's Cabal and Haddock 0.x and I doubt anyone still uses Haddock 0.x and expects modern tools interacting with it to work.
@23Skidoo 23Skidoo mentioned this issue Apr 23, 2014
Closed
iainnicol added a commit to iainnicol/cabal that referenced this issue May 9, 2014
@iainnicol
Remove support for Haddock versions < 2.0
5b5b741 
This will allow code to be simplified.  Currently we preprocess both
Literate Haskell files and Haskell files requiring the CPP, but newer
versions of Haddock can handle these natively.

Fixes issue haskell#1718.
iainnicol added a commit to iainnicol/cabal that referenced this issue May 10, 2014
@iainnicol
Remove support for Haddock versions < 2.0
98c537f 
Dropping this support is unlikely to be a problem in practice.  Debian
oldstable is currently on version 2.6.0 of Haddock, for example.

This change enables future code simplification.  Currently we
preprocess both Haskell files requiring the CPP and Literate Haskell
files; newer versions of Haddock can handle these natively.

Fixes issue haskell#1718.
mzero pushed a commit to mzero/cabal that referenced this issue Jul 23, 2014
@iainnicol @mzero
Remove support for Haddock versions < 2.0
b1957de 
Dropping this support is unlikely to be a problem in practice.  Debian
oldstable is currently on version 2.6.0 of Haddock, for example.

This change enables future code simplification.  Currently we
preprocess both Haskell files requiring the CPP and Literate Haskell
files; newer versions of Haddock can handle these natively.

Fixes issue haskell#1718.

Conflicts:
	Cabal/Distribution/Simple/Haddock.hs
	Cabal/Distribution/Simple/PreProcess.hs
	Cabal/Distribution/Simple/Setup.hs
tibbe pushed a commit that referenced this issue Jul 27, 2014
@iainnicol @tibbe
Remove support for Haddock versions < 2.0
e945945 
Dropping this support is unlikely to be a problem in practice.  Debian
oldstable is currently on version 2.6.0 of Haddock, for example.

This change enables future code simplification.  Currently we
preprocess both Haskell files requiring the CPP and Literate Haskell
files; newer versions of Haddock can handle these natively.

Fixes issue #1718.

(cherry picked from commit 98c537f)
@ttuegel ttuegel added this to the _|_ milestone Apr 23, 2015
@ulysses4ever
Copy link
Collaborator

This has been fixed in 98c537f (it appears), I wonder why the issue wasn't auto-closed. Closing?

@Fuuzetsu
Copy link
Member Author

You're probably correct, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cabal-install: cmd/haddock type: enhancement type: refactor
Projects
None yet
Milestone
⊥
Development

No branches or pull requests
4 participants
@ttuegel @Fuuzetsu @gbaz @ulysses4ever