Prevent dependency on private library

haskell · Jan 16, 2019 · af482b4 · af482b4
1 parent c3c29a4
commit af482b4
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/Cabal/Distribution/Simple/Configure.hs b/Cabal/Distribution/Simple/Configure.hs
@@ -83,6 +83,7 @@ import Distribution.Types.LegacyExeDependency
 import Distribution.Types.PkgconfigDependency
 import Distribution.Types.LocalBuildInfo
 import Distribution.Types.LibraryName
+import Distribution.Types.LibraryVisibility
 import Distribution.Types.ComponentRequestedSpec
 import Distribution.Types.ForeignLib
 import Distribution.Types.ForeignLibType
@@ -899,9 +900,9 @@ dependencySatisfiable
 
           || all
                (\lib ->
-                 (depName, CLibName lib)
-                 `Map.member`
-                 requiredDepsMap)
+                 let maybeIPI =
+                       (depName, CLibName lib) `Map.lookup` requiredDepsMap
+                 in (Just LibraryVisibilityPublic) == (Installed.libVisibility <$> maybeIPI))
                sublibs
 
     | isInternalDep
@@ -965,7 +966,7 @@ configureFinalizedPackage verbosity cfg enabled
                    pkg_descr0
             of Right r -> return r
                Left missing ->
-                   die' verbosity $ "Encountered missing dependencies:\n"
+                   die' verbosity $ "Encountered missing or private dependencies:\n"
                      ++ (render . nest 4 . sep . punctuate comma
                                 . map (pretty . simplifyDependency)
                                 $ missing)